[release-4.22] revert disk size to 31G and add workaround for download pods disk usuage.#1247
Conversation
Walkthrough
Changessnc.sh and transient-ro mount update
Estimated code review effort: 2 (Simple) | ~5 minutes Possibly related PRs
Suggested labels: Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
snc.sh (1)
218-221: ⚡ Quick winConsolidate the duplicated downloads-pod workaround into a helper.
Line 218 and Line 280 repeat the same delete+wait sequence; extracting a small function avoids drift when this workaround is updated later.
♻️ Proposed refactor
+# Workaround for OCPBUGS-88450 +restart_console_downloads_pods() { + retry ${OC} delete pod -n openshift-console -l app=console,component=downloads + retry ${OC} wait --for=condition=Ready pod -n openshift-console -l app=console,component=downloads --timeout=60s +} + -# Remove the downloads pods because of https://redhat.atlassian.net/browse/OCPBUGS-88450 -# as workaround -retry ${OC} delete pod -n openshift-console -l app=console,component=downloads -retry ${OC} wait --for=condition=Ready pod -n openshift-console -l app=console,component=downloads --timeout=60s +restart_console_downloads_pods @@ -# Remove the downloads pods because of https://redhat.atlassian.net/browse/OCPBUGS-88450 -# as workaround -retry ${OC} delete pod -n openshift-console -l app=console,component=downloads -retry ${OC} wait --for=condition=Ready pod -n openshift-console -l app=console,component=downloads --timeout=60s +restart_console_downloads_podsAlso applies to: 280-283
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@snc.sh` around lines 218 - 221, The delete and wait operations for the downloads pods workaround (retry ${OC} delete pod and retry ${OC} wait commands) are duplicated at lines 218-221 and lines 280-283. Extract this repeated sequence into a dedicated helper function, then call that function from both locations to eliminate duplication and ensure any future updates to the workaround are consistently applied everywhere it is used.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@snc.sh`:
- Around line 218-221: The delete and wait operations for the downloads pods
workaround (retry ${OC} delete pod and retry ${OC} wait commands) are duplicated
at lines 218-221 and lines 280-283. Extract this repeated sequence into a
dedicated helper function, then call that function from both locations to
eliminate duplication and ensure any future updates to the workaround are
consistently applied everywhere it is used.
Looks like it was happening because of https://redhat.atlassian.net/browse/OCPBUGS-88450 one This reverts commit ba3ba79.
praveenkumar
force-pushed
the
fix_disk_size_4.22
branch
from
33954c8 to
52c8272
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@99-enable-transient-ro.yaml`:
- Line 44: The ExecStart command in the transient root override uses a mount
option unsupported by this RHCOS/util-linux base, so the remount step will fail
and the symlink setup in the same shell will never happen. Update the command in
the systemd unit to use a remount approach compatible with RHCOS 9.8 and keep
the `/Users` symlink creation tied to the successful remount path. Make sure the
fix is applied in the override that defines ExecStart so the startup behavior is
reliable even when the shell prefix ignores nonzero exit codes.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 2840fe0b-59fd-41ef-aca3-a0735890e747
📒 Files selected for processing (2)
99-enable-transient-ro.yamlsnc.sh
|
/retest |
1 similar comment
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anjannath The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
Bot
merged commit 65ae637
into
crc-org:release-4.22
2 participants
Summary by CodeRabbit